Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PackageSecurityHealthCheck and Tests #36

Merged

Conversation

srichter
Copy link
Contributor

@srichter srichter commented Oct 5, 2020

This creates PackageSecurityHealthCheck which uses sensiolabs/security-checker to check your project's composer.lock for packages which have known vulnerabilities. It includes full test coverage.

@srichter
Copy link
Contributor Author

srichter commented Oct 5, 2020

Is Laravel 5.4 support still desired for this package? I can fix the tests further

@tylerwoonton
Copy link
Contributor

@srichter Yeah, we support Laravel 5.4. If you wouldn't mind fixing the PHP 5.6 tests, that'd be great.

@Gman98ish
Copy link
Contributor

@srichter

Code looks great, tests are all working, and it's a really cool idea.

Just for my own understanding, what's the use case for this? From what I can tell, this package just checks your composer.lock file, which doesn't change depending on your environment. So with that in mind, why would you use it in a health check over using the CLI tool directly?

(I might be mistaken with how the package works)

@srichter
Copy link
Contributor Author

srichter commented Oct 8, 2020

My thinking was that it would be good for in-production applications that aren't having much active development, so the packages might be outdated (and possibly vulnerable). You could always easily run the console command, but having up-to-date information on the /health endpoint allows the metric to be monitored.

@Gman98ish Gman98ish merged commit a92184c into ans-group:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants