fix: deleting inline file should delete file in the list as well [ch1…

…8037] (#412)
anri-asaturov · Jan 4, 2019 · 461f286 · 461f286
1 parent 478155a
commit 461f286
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/app/components/files/file-state.js b/app/components/files/file-state.js
@@ -61,7 +61,16 @@ class FileState extends RoutedState {
     }
 
     @action
-    async deleteFile(file) {
+    async deleteFile(fileInfo) {
+        const id = fileInfo.fileId;
+        let file = fileStore.getById(id);
+        if (!file) {
+            file = await fileStore.loadKegByFileId(id);
+            if (!file) {
+                console.error(`could not resolve a file ${id}`);
+                return Promise.resolve();
+            }
+        }
         const isOwner = file.owner === User.current.username;
         const title = isOwner ? tx('dialog_confirmDeleteFile') : tx('title_confirmRemoveFile');
         let subtitle = '';

diff --git a/app/components/files/file-upload-action-sheet.js b/app/components/files/file-upload-action-sheet.js
@@ -11,7 +11,12 @@ import ActionSheetLayout from '../layout/action-sheet-layout';
 
 async function doUpload(sourceFunction, inline) {
     const uploader = inline ? fileState.uploadInline : fileState.uploadInFiles;
-    const source = observable(await sourceFunction());
+    const uploadInfo = await sourceFunction();
+    if (!uploadInfo) {
+        console.log(`no upload info provided. skipping upload`);
+        return;
+    }
+    const source = observable(uploadInfo);
     if (inline) {
         const userSelection = await FileSharePreview.popup(source.url, source.fileName);
         if (!userSelection) return;

diff --git a/app/components/helpers/imagepicker.ts b/app/components/helpers/imagepicker.ts
@@ -55,6 +55,10 @@ async function processResponse(functor, params?) {
     if (!response.path && response.uri) {
         response.path = response.uri;
     }
+    if (!response.path) {
+        console.log(`user cancelled image selection. no path returned`);
+        return null;
+    }
     // if it's a HEIF or HEIC file, it would still give you path to JPG asset
     // for the sake of compatibility
     const ext = fileHelpers