Fix Not tagging Non-Release branches #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
According to the documentation non-release "branches and pull-requests generate versions postfixed with the commit hash and do not generate any tag."
This was not working correctly and tags were being created on all commits regardless of the branch being in
RELEASE_BRANCHES.This change disables tagging when it is a non-release branch. It also adds the branch name as a suffix instead of using the commit hash.
Breaking Changes
Do any of the included changes break current behavior or configuration?
YES for anyone relying on tagging for non-release branches.
How changes have been tested