Improve HVAC action detection and event handling for OWN dimension '20' #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced climate entity logic to better determine HVAC actions based on current mode and message state. Added explicit handling for OWNHeatingEvent with dimension 20 in gateway to ensure climate entities update their state promptly.
Added a check to process OWNHeatingEvent messages with dimension 20 only when 'where' is not zero. This prevents unnecessary event handling and state updates for messages with 'where' equal to zero.
Updated climate.py to only set HVAC action when message is active and 'where' is not '0'. Removed redundant 'where' check in gateway.py for OWNHeatingEvent, ensuring all such events are processed regardless of 'where' value.
If where 0 and dimesnion 20, do not change HVAC action, because where 0 is not a single thermostat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced climate entity logic to improve HVAC action detection based on the current mode and message state. Added explicit handling for OWNHeatingEvent with dimension 20 in the gateway to ensure climate entities update their state promptly.
With this modification, when a message has who=4 and dimension=20, HVAC actions are now displayed correctly.