Open
Conversation
New env variables: DB_SSL=false|true MYSQL_ATTR_SSL_CA=null|/path/to/ca/certificates.crt
Contributor
|
From the first glance this looks good. |
crazy-max
requested changes
Jan 22, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Needs rebase following this change https://github.com/anonaddy/docker/pull/310/files#diff-6612a04c84d4ff0900226884a0ff714b8913ce20a3afa05d03f31ddd9903180f
Would be better to have this configurable through my.cnf.d conf to have this propagated to the client directly without flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for connecting to MySQL DB over TLS/SSL, as a solution to #199.
New variables added to support this option:
Descriptions of the new variables added in the
READMEfile.Ended up implementing much simpler option than anticipated in #199, since the PHP app would either connect to the DB without TLS or with TLS and certificate verification.
So the only options are to either turn on or off the connection over TLS and potentially to provide a custom CA certificate. MySQL server's certificate verification is always on when connection over TLS is on.