Skip to content

Passing deploy role to stack params #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fwang merged 4 commits into from
Aug 14, 2025
Merged

Passing deploy role to stack params #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0ea033
Passing deploy role to stack params
hoangnd25 Jul 7, 2025
9c82e83
Replace placeholders
hoangnd25 Jul 7, 2025
fbc41c9
Allows overriding cloudFormationExecutionRole
hoangnd25 Jul 7, 2025
dc702c7
sync
Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/crazy-cobras-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"sst": patch
---

Passing deploy role to stack params
18 changes: 11 additions & 7 deletions packages/sst/src/stacks/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import path from "path";
import { useBus } from "../bus.js";
import { useProject } from "../project.js";
import { ConfigOptions, useProject } from "../project.js";
import { useAWSClient, useAWSProvider } from "../credentials.js";
import { Logger } from "../logger.js";
import { type CloudFormationStackArtifact } from "aws-cdk-lib/cx-api";
Expand All @@ -15,6 +15,7 @@ import { VisibleError } from "../error.js";

export async function publishAssets(stacks: CloudFormationStackArtifact[]) {
Logger.debug("Publishing assets");
const { cdk } = useProject().config;

const results: Record<string, any> = {};
for (const stackArtifact of stacks) {
Expand All @@ -24,7 +25,7 @@ export async function publishAssets(stacks: CloudFormationStackArtifact[]) {
await buildAndPublishAssets(deployment, stackArtifact);
results[stackArtifact.stackName] = {
isUpdate: cfnStack && cfnStack.StackStatus !== "REVIEW_IN_PROGRESS",
params: await buildCloudFormationStackParams(deployment, stackArtifact),
params: await buildCloudFormationStackParams(deployment, stackArtifact, cdk),
};
}
return results;
Expand Down Expand Up @@ -120,7 +121,7 @@ export async function deploy(
await deleteCloudFormationStack(stack.stackName);
}

const stackParams = await buildCloudFormationStackParams(deployment, stack);
const stackParams = await buildCloudFormationStackParams(deployment, stack, cdk);
try {
cfnStack && cfnStack.StackStatus !== "REVIEW_IN_PROGRESS"
? await updateCloudFormationStack(stackParams)
Expand Down Expand Up @@ -295,22 +296,25 @@ async function buildAndPublishAssets(

async function buildCloudFormationStackParams(
deployment: any,
stack: CloudFormationStackArtifact
stack: CloudFormationStackArtifact,
cdkOptions?: ConfigOptions["cdk"]
) {
const resolvedEnv = await deployment.resolveEnvironment(stack);
const env = await deployment.envs.accessStackForMutableStackOperations(stack);
const executionRoleArn = cdkOptions?.cloudFormationExecutionRole ?? await env.replacePlaceholders(stack.cloudFormationExecutionRoleArn);
const s3Url = stack
.stackTemplateAssetObjectUrl!.replace(
"${AWS::AccountId}",
resolvedEnv.account
env.resolvedEnvironment.account
)
.match(/s3:\/\/([^/]+)\/(.*)$/);
const templateUrl = s3Url
? `https://s3.${resolvedEnv.region}.amazonaws.com/${s3Url[1]}/${s3Url[2]}`
? `https://s3.${env.resolvedEnvironment.region}.amazonaws.com/${s3Url[1]}/${s3Url[2]}`
: stack.stackTemplateAssetObjectUrl;

return {
StackName: stack.stackName,
TemplateURL: templateUrl,
RoleARN: executionRoleArn,
//TemplateBody: bodyParameter.TemplateBody,
//Parameters: stackParams.apiParameters,
Parameters: [],
Expand Down