Bugfix: Handle failed type assertions gracefully in completed.go #6354
+45
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Fixes #6235
getCompletedEvents trusts the outputs in state to be the expected type / shape.
If resource outputs in state contain unexpected fields or types (due to other bugs, or user error), then the cli crashes unexpectedly leading to confusing errors.
These errors are also difficult to recover from without manually altering the state file directly.
This PR just adds purely defenesive code / type assertions to ensure the data is the correct type before acting upon it.
There is no change to functionality or logic.