Fix dev command timeout / restart #6351
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6345
The timeout timer was being recreated every time a deployment completion event happened as the timer was initilised within the event loop, this means if you are changing stack code and deploying within the ~50 minute window, then the timer would reset, even though the dev task is still running.
To reproduce the original issue:
set
timeout := time.Seconds * 30With a long running task, e.g.:
Save / touch the sst.config.ts file, which causes a deployment from the watcher.
Note that the timeout and restart never occurs, and the command eventually exits.
With the change in this PR, this issue is resolved and the dev command restarts as expected after 30 seconds, regardless of deployments completing.