fix: race condition in basic mode server startup #6318
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsonti23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition causing sst dev --mode=basic to hang on startup
In basic mode, the UI client was attempting to connect to the HTTP server before it was ready to accept connections, resulting in "connection refused" errors and causing the application to hang
indefinitely.
Root cause: server.Start() runs in a goroutine while CmdUI() immediately tries to connect, creating a race between server initialization and client connection.
Solution:
• Added a Ready channel to the Server struct that signals when the server is listening
• Modified basic mode to wait on <-server.Ready before starting the UI
• Close the Ready channel after net.Listen() succeeds (and on error to prevent infinite hangs)
fixes #3990