fix: emit INPUT event for all mutating edit actions in InputRenderable#664
Merged
kitlangton merged 3 commits intomainfrom Feb 10, 2026
Merged
fix: emit INPUT event for all mutating edit actions in InputRenderable#664kitlangton merged 3 commits intomainfrom
kitlangton merged 3 commits intomainfrom
Conversation
InputRenderable.deleteWordBackward() (inherited from Textarea) mutates the buffer but never emits INPUT, so consumers like DialogSelect never see the value change.
Override deleteWordBackward, deleteWordForward, deleteToLineStart, deleteToLineEnd, undo, and redo to emit INPUT after the super call, matching the existing pattern for deleteCharBackward and deleteChar. Fixes Ctrl+W / Alt+Backspace not updating search results in TUI dialog filters (e.g. model picker, skill picker).
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
simonklee
reviewed
Feb 10, 2026
Collaborator
simonklee
left a comment
simonklee
left a comment
There was a problem hiding this comment.
Are we also missing deleteLine for Ctrl+Shift+D?
Covers the Ctrl+Shift+D (delete-line) action that was also missing INPUT event emission.
Collaborator
Author
Indeed! Fixed :) |
simonklee
approved these changes
Feb 10, 2026
Collaborator
simonklee
left a comment
simonklee
left a comment
There was a problem hiding this comment.
I think this looks good. Tests passed locally and didn't find anything other than the missing event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputRenderable now emits INPUT events for all text-mutating operations (Ctrl+W, Ctrl+U, Ctrl+K, undo/redo), not just single-character deletion. Fixes search filters in TUI dialogs that rely on onInput events.
Test plan