feat: Auto-focus on click (browser-like behavior)#584
Merged
kommander merged 10 commits intoanomalyco:mainfrom Jan 30, 2026
Merged
feat: Auto-focus on click (browser-like behavior)#584kommander merged 10 commits intoanomalyco:mainfrom
kommander merged 10 commits intoanomalyco:mainfrom
Conversation
Automatically focus the closest focusable ancestor when clicking with the left mouse button. This matches browser behavior where clicking inside a focusable container focuses it. - Walks up parent chain to find first focusable element - Works with scrollbox, input, textarea, select components - Adds test coverage for focus-on-click behavior Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
kommander
reviewed
Jan 25, 2026
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
Fire mousedown event before auto-focus so handlers can call preventDefault() to cancel the default focus behavior (browser-like). Adds tests for preventDefault and verifies mousedown fires only once. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
I added test coverage for the mouse data handler on main. Can you merge that in or let me push to your branch? |
Contributor
Author
I updated the branch and gave permission to push to the branch just in case you need to modify it still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #576
Problem
Currently, clicking on a focusable element (input, scrollbox, etc.) doesn't automatically focus it. Users must manually handle
onMouseDownto set focus state, which is different from browser behavior.Proposed Solution
Add browser-like auto-focus behavior to the renderer:
focus()on the clicked elementisWithinContainerBenefits
onMouseDownhandlers needed)focusedBorderColor/focusedBackgroundColorstyle props