Skip to content

Feat/select all textarea#558

Merged
kommander merged 8 commits intoanomalyco:mainfrom
danolekh:feat/select-all-textarea
Jan 26, 2026
Merged

Feat/select all textarea#558
kommander merged 8 commits intoanomalyco:mainfrom
danolekh:feat/select-all-textarea

Conversation

@danolekh
Copy link
Contributor

@danolekh danolekh commented Jan 20, 2026

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 20, 2026

@opentui/core

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core@558

@opentui/react

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/react@558

@opentui/solid

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/solid@558

@opentui/core-darwin-arm64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-darwin-arm64@558

@opentui/core-darwin-x64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-darwin-x64@558

@opentui/core-linux-arm64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-linux-arm64@558

@opentui/core-linux-x64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-linux-x64@558

@opentui/core-win32-arm64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-win32-arm64@558

@opentui/core-win32-x64

npm i https://pkg.pr.new/anomalyco/opentui/@opentui/core-win32-x64@558

commit: 33cdf58

@kommander
Copy link
Collaborator

@danolekh will you fix the tests or is there something more to consider?

@danolekh
Copy link
Contributor Author

@kommander yes, i will fix

@danolekh danolekh requested a review from simonklee as a code owner January 24, 2026 19:21
@danolekh
Copy link
Contributor Author

should be fixed now

Comment on lines 766 to 770
const selection = this._ctx.getSelection()
if (selection) {
selection.isDragging = false
this.onSelectionChanged(selection)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to consider this extra block for a moment, as ctx.updateSelection should trigger onSelectionChanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that makes sense, i've updated the code

@kommander kommander merged commit cf0415e into anomalyco:main Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants