Skip to content

Fix wrong Kitty keyboard protocol flags#426

Merged
kommander merged 6 commits intoanomalyco:mainfrom
devxoul:fix-kitty-flags
Dec 22, 2025
Merged

Fix wrong Kitty keyboard protocol flags#426
kommander merged 6 commits intoanomalyco:mainfrom
devxoul:fix-kitty-flags

Conversation

@devxoul
Copy link
Contributor

@devxoul devxoul commented Dec 19, 2025

The Kitty flag values were incorrectly entered in #398

Document: https://sw.kovidgoyal.net/kitty/keyboard-protocol/#id5

Screenshot 2025-12-19 at 7 04 21 PM

@kommander
Copy link
Collaborator

Does that change current behavior?

@devxoul
Copy link
Contributor Author

devxoul commented Dec 22, 2025

@kommander possibly, but I'm not 100% sure what you intendend originally.

I found this typo while I was debugging that key bindings like ctrl+C didn't work in Korean keyboard. In the Korean keyboard the Kitty event was: ctrl+ ( is at the same location of C)

Alternate key flag, as far as I know, converts language specific key events into base keys: ctrl+ into ctrl+C. As the original code at #398 specifies the alternate keys as the default flag, I thought this was the original intention. But this doesn't seem to be working at the moment.

So yeah, the behavior might change, but I believe the new behavior is what it was originally intended.

let flags = KITTY_FLAG_ALTERNATE_KEYS

if (config.events) {
  flags |= KITTY_FLAG_EVENT_TYPES
}

@kommander kommander merged commit 4a84421 into anomalyco:main Dec 22, 2025
4 checks passed
@devxoul
Copy link
Contributor Author

devxoul commented Dec 22, 2025

(FYI) follow-up PR in opencode: anomalyco/opencode#5956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants