Fix wrong Kitty keyboard protocol flags#426
Merged
kommander merged 6 commits intoanomalyco:mainfrom Dec 22, 2025
Merged
Conversation
9e88b99 to
ead23d6
Compare
Collaborator
|
Does that change current behavior? |
Contributor
Author
|
@kommander possibly, but I'm not 100% sure what you intendend originally. I found this typo while I was debugging that key bindings like ctrl+C didn't work in Korean keyboard. In the Korean keyboard the Kitty event was: ctrl+ㅊ (ㅊ is at the same location of C) Alternate key flag, as far as I know, converts language specific key events into base keys: ctrl+ㅊ into ctrl+C. As the original code at #398 specifies the alternate keys as the default flag, I thought this was the original intention. But this doesn't seem to be working at the moment. So yeah, the behavior might change, but I believe the new behavior is what it was originally intended. let flags = KITTY_FLAG_ALTERNATE_KEYS
if (config.events) {
flags |= KITTY_FLAG_EVENT_TYPES
} |
Contributor
Author
|
(FYI) follow-up PR in opencode: anomalyco/opencode#5956 |
msmps
pushed a commit
that referenced
this pull request
Jan 8, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kitty flag values were incorrectly entered in #398
Document: https://sw.kovidgoyal.net/kitty/keyboard-protocol/#id5