fix(share): handle NotFoundError for non-shared sessions in sync #6634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the sync function in share-next.ts would throw a NotFoundError when attempting to sync sessions that haven't been shared. The fix ensures that sync operations gracefully handle non-shared sessions by catching the error and returning early.
Key Changes:
- Added error handling to
get(sessionID)call in the sync function to catchNotFoundErrorand returnundefinedinstead - This allows the sync operation to gracefully exit early when a session is not shared, preventing uncaught errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ruuxi
pushed a commit
to ruuxi/ngmicode
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.