fix(tui): add linear search fallback for session update/delete sync#5518
Closed
cedefrespo wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(tui): add linear search fallback for session update/delete sync#5518cedefrespo wants to merge 1 commit intoanomalyco:devfrom
cedefrespo wants to merge 1 commit intoanomalyco:devfrom
Conversation
Binary.search may fail to find sessions when the store array order differs from expected sort order. This adds a linear search fallback to ensure session updates (rename) and deletes are properly synced to the UI. Fixes anomalyco#5494 Fixes anomalyco#3779
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binary.searchfails to find a session in the storeProblem
The
session.updatedandsession.deletedevent handlers useBinary.searchto find sessions in the store array. However, the binary search can fail to find sessions when the store array order differs from the expected sort order (e.g., due to timing issues or string comparison edge cases).This causes:
Solution
Add a linear search fallback (
Array.findIndex) whenBinary.searchreturnsfound: false. This ensures the session is found and updated in the UI regardless of array ordering.The fix is minimal and defensive - it only runs the linear search if binary search fails, so there's no performance impact in the normal case.
Testing
Ctrl+X L)Ctrl+R)Fixes #5494
Fixes #3779