Repository navigation
fix(core): only send png, jpeg and webp images to xAI - #53787
Merged
Merged
Conversation
xAI rejects other image types such as GIF with a 400 invalid_image. The image stays in the session history, so every later turn fails too. Replace those images with the existing unsupported-media error text, for both user attachments and tool results.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 of 6 tasks
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #53786
Type of change
What does this PR do?
xAI only accepts PNG, JPEG and WebP images. Any other image type, like a GIF, gets a 400
invalid_image. The GIF stays in the history, so every later turn fails too and the session is stuck.For the xAI provider, this swaps other image types for the note v2 already uses when a model can't read some media (
Cannot read "x.gif" (this model does not support image/gif input). Inform the user.). It covers user attachments and read-tool results. It runs when the request is built, so stored messages are unchanged and already stuck sessions work again. Other providers are unchanged.How did you verify your code works?
session-model-request.test.ts; it fails without the change.bun run testandbun typecheckpass inpackages/core.Screenshots / recordings
Input GIF:
Before: the GIF turn and the follow-up both fail with 400.
After: the model says it can't read the GIF, and the follow-up answers.
Checklist