Repository navigation
feat(core): restore session archiving - #53759
Open
Brendonovich wants to merge 1 commit into
Open
Brendonovich wants to merge 1 commit into
Brendonovich wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores session archiving to the V2 API. V1 supported archiving through session updates, but V2 only exposed the stored
time.archivedvalue and had no way to set or clear it.PATCH /api/session/:sessionIDacceptsarchived: boolean.truearchives the session,falserestores it, and repeating the current state is a no-op.GET /api/sessionaccepts an optionalarchivedfilter.truereturns only archived sessions,falseexcludes them, and omitting it keeps the current behavior of returning both. Pagination cursors preserve the filter.session.archivedandsession.unarchivedevents project the archive timestamp. Archiving and unarchiving also updatetime.updated.nullas unarchived, so an archive timestamp of0is preserved.Testing
bun run checkpackages/core:bun test test/session-archive.test.tspackages/server:bun test test/session-update.test.tspackages/schema:bun test test/event-manifest.test.ts