Skip to content

feat(desktop): reserve gray message styling for pending steers - #53758

Closed
usrnk1 wants to merge 3 commits into
v2from
fix-message-pending
Closed

usrnk1 wants to merge 3 commits into
v2from
fix-message-pending

Conversation

@usrnk1

@usrnk1 usrnk1 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

No linked issue; fixes the gray pending-state flash reported in desktop.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

  • Keeps normal sends in their normal message style through optimistic admission and server acknowledgement. Gray remains reserved for pending steers.
  • Checks whether execution is running at admission time, so rapid follow-ups stay pending even when the first send is still preparing.
  • Restores pending styling and queue/delete actions when startup fails or is interrupted before the prompt is delivered.

How did you verify your code works?

  • bun run check and bun run lint:changed passed.
  • 56 focused composer/client tests passed; the two review regressions failed before their fixes.
  • All 27 queue regression tests passed against a production build. Also exercised idle sends, pending steers, and failed startup in the real UI.
  • Compared the production cold-session entry benchmark before/after: stable rendering at 256.6 ms / 270.5 ms in single diagnostic runs, with no wrong-session samples.

Screenshots / recordings

Normal send while idle

Before After
Before: an idle send briefly appears gray and pending After: an idle send keeps its normal styling
Pending steer Undelivered prompt after failed startup
A pending steer remains gray with queue and delete actions Failed startup restores the pending state and its actions

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@Brendonovich

Copy link
Copy Markdown
Member

Replaced by #53880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants