fix(app): correct todo progress count order - #41373
Open
kusune wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41369
Type of change
What does this PR do?
The Japanese
session.todo.progresstranslation placed{{done}}before{{total}}, so the Desktop app displayed0 個中 3 個の Todo が完了when three todos were still pending.The Bengali translation had the same placeholder order.
This changes only those two locale entries. The
SessionTodoDockalready passesdoneandtotalcorrectly, so no runtime logic change is needed. The CLI/TUI is unaffected because it does not render this summary label.How did you verify your code works?
done=0, total=3renders with the total before the completed count.git diff --checkpasses.Screenshots / recordings
The original screenshot is included in #41369. No after-screenshot was produced because the local build environment was unavailable.
Checklist