fix: filter MCP servers from @ autocomplete#14402
Open
dotuananh0712 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: filter MCP servers from @ autocomplete#14402dotuananh0712 wants to merge 1 commit intoanomalyco:devfrom
dotuananh0712 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Prevent MCP servers from appearing in the @ autocomplete menu by filtering out agents whose names start with 'mcps/'. Only agents/subagents should appear in the autocomplete. Fixes anomalyco#14399
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14399
Type of change
What does this PR do?
This PR fixes issue #14399 where MCP servers were appearing in the @ autocomplete menu alongside agents/subagents.
The problem: When users have MCP servers configured (e.g., "notionApi"), they were appearing in the @ autocomplete menu with names like "@mcps/notionApi/", making it confusing when trying to invoke actual agents.
The fix: Added a filter condition in packages/app/src/components/prompt-input.tsx to exclude any agents whose names start with "mcps/" from appearing in the @ autocomplete menu. This ensures only actual agents/subagents are shown in the autocomplete.
How did you verify your code works?
Code follows the existing pattern used for filtering agents (similar to how "hidden" and "primary" mode agents are filtered). The fix is minimal and targeted.
Checklist