Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/opencode/src/session/prompt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,13 +302,18 @@ export namespace SessionPrompt {
}

if (!lastUser) throw new Error("No user message found in stream. This should never happen.")
if (
lastAssistant?.finish &&
!["tool-calls", "unknown"].includes(lastAssistant.finish) &&
lastUser.id < lastAssistant.id
) {
log.info("exiting loop", { sessionID })
break
if (lastAssistant?.finish && !["tool-calls", "unknown"].includes(lastAssistant.finish)) {
if (lastUser.id < lastAssistant.id) {
log.info("exiting loop", { sessionID })
break
} else {
log.warn("assistant finished but user message is newer", {
sessionID,
lastUserId: lastUser.id,
lastAssistantId: lastAssistant.id,
finish: lastAssistant.finish,
})
}
}

step++
Expand Down Expand Up @@ -650,7 +655,7 @@ export namespace SessionPrompt {
}
continue
}
SessionCompaction.prune({ sessionID })
await SessionCompaction.prune({ sessionID })
for await (const item of MessageV2.stream(sessionID)) {
if (item.info.role === "user") continue
const queued = state()[sessionID]?.callbacks ?? []
Expand Down
68 changes: 53 additions & 15 deletions packages/opencode/src/tool/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import { iife } from "@/util/iife"
import { defer } from "@/util/defer"
import { Config } from "../config/config"
import { PermissionNext } from "@/permission/next"
import { Bus } from "../bus"
import { Log } from "../util/log"

const log = Log.create({ service: "tool.task" })

const parameters = z.object({
description: z.string().describe("A short (3-5 words) description of the task"),
Expand Down Expand Up @@ -125,23 +129,57 @@ export const TaskTool = Tool.define("task", async (ctx) => {
using _ = defer(() => ctx.abort.removeEventListener("abort", cancel))
const promptParts = await SessionPrompt.resolvePromptParts(params.prompt)

const result = await SessionPrompt.prompt({
messageID,
sessionID: session.id,
model: {
modelID: model.modelID,
providerID: model.providerID,
},
agent: agent.name,
tools: {
todowrite: false,
todoread: false,
...(hasTaskPermission ? {} : { task: false }),
...Object.fromEntries((config.experimental?.primary_tools ?? []).map((t) => [t, false])),
},
parts: promptParts,
let promptResolved = false

// Listen for child completion signal — if the child's assistant message
// gets a final finish reason or error but the prompt doesn't resolve shortly
// after, force-cancel the child to unblock the parent.
const unsub = Bus.subscribe(MessageV2.Event.Updated, (event) => {
const msg = event.properties.info
if (msg.sessionID !== session.id) return
if (msg.role !== "assistant") return

// Detect terminal states: final finish reason OR error
const hasTerminalFinish =
"finish" in msg && msg.finish && !["tool-calls", "unknown"].includes(msg.finish)
const hasError = "error" in msg && msg.error
if (!hasTerminalFinish && !hasError) return

setTimeout(() => {
if (!promptResolved) {
log.warn("subagent completed but prompt did not resolve, forcing cancel", {
sessionID: session.id,
finish: "finish" in msg ? msg.finish : undefined,
error: hasError,
})
SessionPrompt.cancel(session.id)
}
}, 3000)
})

let result: MessageV2.WithParts
try {
result = await SessionPrompt.prompt({
messageID,
sessionID: session.id,
model: {
modelID: model.modelID,
providerID: model.providerID,
},
agent: agent.name,
tools: {
todowrite: false,
todoread: false,
...(hasTaskPermission ? {} : { task: false }),
...Object.fromEntries((config.experimental?.primary_tools ?? []).map((t) => [t, false])),
},
parts: promptParts,
})
promptResolved = true
} finally {
unsub()
}

const text = result.parts.findLast((x) => x.type === "text")?.text ?? ""

const output = [
Expand Down
Loading