fix(config): handle $ character with {file:} pattern#12390
Merged
rekram1-node merged 1 commit intoanomalyco:devfrom Feb 6, 2026
Merged
fix(config): handle $ character with {file:} pattern#12390rekram1-node merged 1 commit intoanomalyco:devfrom
rekram1-node merged 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Duplicate PR Found
|
Collaborator
|
/review |
Contributor
|
lgtm |
Colin4k1024
pushed a commit
to Colin4k1024/opencode
that referenced
this pull request
Feb 10, 2026
Co-authored-by: Hank Stoever <1109058+hstove@users.noreply.github.com>
3 tasks
schneiderlo
pushed a commit
to schneiderlo/opencode
that referenced
this pull request
Feb 17, 2026
Co-authored-by: Hank Stoever <1109058+hstove@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
{env:...}variable substitution inconsistently fails for specific MCP server URLs #5299This PR fixes an issue where files containing
$would break opencode when your config used the{file:x}pattern. This is becauseString.prototype.replacetreats$as a replacement character, which is not what we want in this use case. This PR instead uses a replacement function, so that.replacedoes a "dumb" string replacement.There is an alternative PR: #11795 . I respectfully believe that that PR's approach is flawed as it tries to escape the
$, instead of just treating the$as-is.How did you verify your code works?