-
Notifications
You must be signed in to change notification settings - Fork 9.2k
fix(opencode): fix issues with glob behaviour for config instructions… #11316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix(opencode): fix issues with glob behaviour for config instructions… #11316
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
|
Nice find, it looks like ur commit history got messed up can you merge dev into your branch or rebase so the diff is clear? |
|
the repeated force pushing onto dev has made this branch very sad. i've run out of time to fix this today, so will come back to it tommorrow... |
56c6d3e to
183e6e5
Compare
… and changes to support testing global instructions
183e6e5 to
dfcd031
Compare
|
@rekram1-node should be sorted now |
… and changes to support testing global instructions
What does this PR do?
Changes to
instuctions.tsto correct path loading behviour so the full range of glob patterns work.Previously
**globs would get parse out bypath.dirname(actually resulting in a file not found error which was silent).I suspect this was probably related to #8892, and maybe some other issues around instructions being ignored.
Fixes #11317
How did you verify your code works?
Added tests to
instructions.test.tsto cover cases for globs and global config instructions which seemed to not previously covered.It's worth noting, whilst digging around the tests and code, getting the tests to ignore my actual homedir was very challenging do to the inconsistent use of
Global.path.home,Global.path.configandos.homedir().