Skip to content

Conversation

@elliotsegler
Copy link

@elliotsegler elliotsegler commented Jan 30, 2026

… and changes to support testing global instructions

What does this PR do?

Changes to instuctions.ts to correct path loading behviour so the full range of glob patterns work.

Previously ** globs would get parse out by path.dirname (actually resulting in a file not found error which was silent).

I suspect this was probably related to #8892, and maybe some other issues around instructions being ignored.

Fixes #11317

How did you verify your code works?

Added tests to instructions.test.ts to cover cases for globs and global config instructions which seemed to not previously covered.

It's worth noting, whilst digging around the tests and code, getting the tests to ignore my actual homedir was very challenging do to the inconsistent use of Global.path.home, Global.path.config and os.homedir().

@github-actions
Copy link
Contributor

Hey! Your PR title bug(opencode): fix issues with glob behaviour for config instructions… doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@elliotsegler elliotsegler changed the title bug(opencode): fix issues with glob behaviour for config instructions… fix(opencode): fix issues with glob behaviour for config instructions… Jan 30, 2026
@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@rekram1-node
Copy link
Collaborator

Nice find, it looks like ur commit history got messed up can you merge dev into your branch or rebase so the diff is clear?

@elliotsegler
Copy link
Author

the repeated force pushing onto dev has made this branch very sad. i've run out of time to fix this today, so will come back to it tommorrow...

@elliotsegler elliotsegler force-pushed the bug/fix-instruction-globs branch from 56c6d3e to 183e6e5 Compare January 30, 2026 23:40
… and changes to support testing global instructions
@elliotsegler elliotsegler force-pushed the bug/fix-instruction-globs branch from 183e6e5 to dfcd031 Compare January 30, 2026 23:55
@elliotsegler
Copy link
Author

@rekram1-node should be sorted now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

file path globs aren't properly parsed in the config instructions field

2 participants