fix: resolve homebrew upgrade requiring multiple runs (#5375)#10118
fix: resolve homebrew upgrade requiring multiple runs (#5375)#10118rekram1-node merged 2 commits intoanomalyco:devfrom
Conversation
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
| HOMEBREW_NO_AUTO_UPDATE: "1", | ||
| ...process.env, | ||
| }) | ||
| // Don't set HOMEBREW_NO_AUTO_UPDATE - let brew auto-update taps before upgrading |
There was a problem hiding this comment.
I don't see why we'd need to do this? Im not a brew expert but why would we need to update other brew deps? I feel like HOMEBREW_NO_AUTO_UPDATE exists for the exact reason we are using it no?
There was a problem hiding this comment.
ohh nice catch. Not a homebrew expert either. The command worked for me without the flag.
Making changes
GeneCodeSavvy
force-pushed
the
fix-5375-homebrew-upgrade
branch
2 times, most recently
from
b11dcda to
0910947
Compare
|
@rekram1-node After gpting this command would be the best workaround. wdyt? |
Not sure im following |
What I’m proposing is: we just git pull our tap repo directly, then run brew upgrade on that formula. That way we only update anomalyco/tap and don’t touch homebrew-core or other taps. |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
4 times, most recently
from
f1ae801 to
08fa7f7
Compare
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…f API Use `brew info --json=v2` to get the latest version directly from Homebrew instead of fetching from formulae.brew.sh API. This provides more accurate version information and reduces external dependencies. Also removes HOMEBREW_NO_AUTO_UPDATE flag from upgrade command.
GeneCodeSavvy
force-pushed
the
fix-5375-homebrew-upgrade
branch
from
4df9493 to
b01ea71
Compare
|
@rekram1-node, I have addressed the review comments. Thanks |
|
/review |
|
lgtm |
2 participants
Fixes #5375
The root cause was that for tap-installed formulas, version detection could fall back to a stale source and Homebrew’s auto-update behavior was being suppressed, so users wouldn’t always see the latest tap changes on the first run.
What does this PR do?
Remove HOMEBREW_NO_AUTO_UPDATE: Let brew auto-update taps before
upgrading (default behavior)
Fix version detection for tap formulas: Use
brew info --json=v2for tap formulas instead of falling back to npm registry
UPDATE:
git pullonly the "anomalyco/tap" tap repobrew upgradefor the "anomalyco/tap/opencode"How did you verify your code works?
Running the command
bun run dev upgrade --print-logs