Skip to content

Commit

Permalink
ci: fixed issues with the new ci
Browse files Browse the repository at this point in the history
  • Loading branch information
prisis committed Jul 22, 2024
1 parent bc80e2d commit bb37caf
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 25 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ permissions:
contents: "read" # to fetch code (actions/checkout)

env:
NX_BRANCH: "${{ github.event.number }}"
NX_RUN_GROUP: "${{ github.run_id }}"
HEAD_REF: "${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }}"
HEAD_REPOSITORY: "${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name || github.repository }}"

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/semantic-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ jobs:

- name: "test and coverage"
run: "pnpm run test:coverage"

- name: "Upload code coverage to codecov"
uses: "anolilab/workflows/step/codecov@main"
with:
run-lint: "false"
codecov-token: "${{ secrets.CODECOV_TOKEN }}"
# @TODO: Enable it later
# - name: "Upload code coverage to codecov"
# uses: "anolilab/workflows/step/codecov@main"
# with:
# run-lint: "false"
# codecov-token: "${{ secrets.CODECOV_TOKEN }}"

- name: "Semantic Release"
if: "success()"
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,14 @@ jobs:
- name: "Run tests"
shell: "bash"
run: "pnpm run test:coverage"

- name: "Upload code coverage to codecov"
if: "matrix.os == 'ubuntu-latest' && matrix.node_version == 18"
uses: "anolilab/workflows/step/codecov@main"
with:
run-lint: true
codecov-token: "${{ secrets.CODECOV_TOKEN }}"
use-affected: false
# @TODO: Enable it later
# - name: "Upload code coverage to codecov"
# if: "matrix.os == 'ubuntu-latest' && matrix.node_version == 18"
# uses: "anolilab/workflows/step/codecov@main"
# with:
# run-lint: true
# codecov-token: "${{ secrets.CODECOV_TOKEN }}"
# use-affected: false

# This check runs once all dependant jobs have passed
# It symbolizes that all required checks have successfully passed (Or skipped)
Expand Down
7 changes: 6 additions & 1 deletion audit-ci.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@
"low": true,
"package-manager": "pnpm",
"report-type": "important",
"allowlist": []
"allowlist": [
// Is used only in the examples
// GHSA-35jh-r3h4-6jhm|. > @rspack/plugin-html@0.5.8 > lodash.template@4.5.0
// GHSA-35jh-r3h4-6jhm|examples/rspack > @rspack/plugin-html@0.5.8 > lodash.template@4.5.0
"GHSA-35jh-r3h4-6jhm"
]
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"@types/ssri": "^7.1.5",
"@visulima/packem": "^1.0.0-alpha.55",
"@vitest/coverage-v8": "^2.0.4",
"audit-ci": "^6.6.1",
"audit-ci": "^7.1.0",
"caniuse-lite": "^1.0.30001643",
"commitizen": "^4.3.0",
"commitlint": "^19.3.0",
Expand Down
25 changes: 18 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bb37caf

Please sign in to comment.