Skip to content

Commit

Permalink
Merge pull request kubernetes#60642 from rajansandeep/removepodaffinity
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Reverting the anti-affinity from CoreDNS pods

**What this PR does / why we need it**:
Following kubernetes#54164 and kubernetes#59357, removing the anti-affinity from CoreDNS.
 
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
  • Loading branch information
Kubernetes Submit Queue committed Mar 7, 2018
2 parents bad8e0d + 0c07f7d commit e9f996b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 57 deletions.
18 changes: 3 additions & 15 deletions cluster/addons/dns/coredns.yaml.base
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ data:
.:53 {
errors
health
kubernetes __PILLAR__DNS__DOMAIN__ __PILLAR__CLUSTER_CIDR__ {
kubernetes __PILLAR__DNS__DOMAIN__ in-addr.arpa ip6.arpa {
pods insecure
upstream /etc/resolv.conf
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus :9153
Expand Down Expand Up @@ -98,21 +98,9 @@ spec:
effect: NoSchedule
- key: "CriticalAddonsOnly"
operator: "Exists"
affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
labelSelector:
matchExpressions:
- key: k8s-app
operator: In
values:
- coredns
topologyKey: kubernetes.io/hostname
containers:
- name: coredns
image: coredns/coredns:1.0.4
image: coredns/coredns:1.0.6
imagePullPolicy: IfNotPresent
resources:
limits:
Expand Down
18 changes: 3 additions & 15 deletions cluster/addons/dns/coredns.yaml.in
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ data:
.:53 {
errors
health
kubernetes {{ pillar['dns_domain'] }} {{ pillar['service_cluster_ip_range'] }} {
kubernetes {{ pillar['dns_domain'] }} in-addr.arpa ip6.arpa {
pods insecure
upstream /etc/resolv.conf
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus :9153
Expand Down Expand Up @@ -98,21 +98,9 @@ spec:
effect: NoSchedule
- key: "CriticalAddonsOnly"
operator: "Exists"
affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
labelSelector:
matchExpressions:
- key: k8s-app
operator: In
values:
- coredns
topologyKey: kubernetes.io/hostname
containers:
- name: coredns
image: coredns/coredns:1.0.4
image: coredns/coredns:1.0.6
imagePullPolicy: IfNotPresent
resources:
limits:
Expand Down
18 changes: 3 additions & 15 deletions cluster/addons/dns/coredns.yaml.sed
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ data:
.:53 {
errors
health
kubernetes $DNS_DOMAIN $SERVICE_CLUSTER_IP_RANGE {
kubernetes $DNS_DOMAIN in-addr.arpa ip6.arpa {
pods insecure
upstream /etc/resolv.conf
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus :9153
Expand Down Expand Up @@ -98,21 +98,9 @@ spec:
effect: NoSchedule
- key: "CriticalAddonsOnly"
operator: "Exists"
affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
labelSelector:
matchExpressions:
- key: k8s-app
operator: In
values:
- coredns
topologyKey: kubernetes.io/hostname
containers:
- name: coredns
image: coredns/coredns:1.0.4
image: coredns/coredns:1.0.6
imagePullPolicy: IfNotPresent
resources:
limits:
Expand Down
12 changes: 0 additions & 12 deletions cmd/kubeadm/app/phases/addons/dns/manifests.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,18 +243,6 @@ spec:
operator: Exists
- key: {{ .MasterTaintKey }}
effect: NoSchedule
affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- weight: 100
podAffinityTerm:
labelSelector:
matchExpressions:
- key: k8s-app
operator: In
values:
- coredns
topologyKey: kubernetes.io/hostname
containers:
- name: coredns
image: coredns/coredns:{{ .Version }}
Expand Down

0 comments on commit e9f996b

Please sign in to comment.