Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets enabled for PRs #454

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Secrets enabled for PRs #454

wants to merge 1 commit into from

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented May 12, 2023

No description provided.

@pseusys pseusys added the bug Something isn't working label May 12, 2023
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@pseusys
Copy link
Collaborator Author

pseusys commented May 27, 2023

... and what are we waiting for?

Copy link
Collaborator

@MarkenJaden MarkenJaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@MarkenJaden
Copy link
Collaborator

Yeah, so everything seems to be stuck until this is solved. Can't we just directly commit to ci.yml?

This whole repo can't continue updating until this is solved..

@pseusys
Copy link
Collaborator Author

pseusys commented Jun 7, 2023

Yeah, so everything seems to be stuck until this is solved. Can't we just directly commit to ci.yml?

This whole repo can't continue updating until this is solved..

Personally I can't merge it, sorry :(

@pseusys pseusys marked this pull request as draft August 11, 2023 03:24
@pseusys
Copy link
Collaborator Author

pseusys commented Aug 11, 2023

This PR won't work: secrets are still not available in PRs, with pull_request_target the main branch code will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants