Added tests and coverage (#3)

* Added tests & coverage

.circleci/config.yml

@@ -9,9 +9,13 @@ jobs:
       - checkout
       - node/install-packages
       - run: 
-          name: Running npm pretest
+          name: Running npm test
           command: |
-            npm run pretest
+            npm run test
+      - run:
+          name: Codecov coverage
+          command: |
+            npm run coverage
       - setup_remote_docker:
           version: 18.06.0-ce
       - run:

.dockerignore

@@ -1,4 +1,5 @@
 node_modules
 .env
 .git
-trash
+trash
+coverage

.eslintrc.yml

@@ -2,6 +2,7 @@ env:
   browser: true
   commonjs: true
   es2020: true
+  jest: true
 extends:
   - standard
 parserOptions:

.gitignore

@@ -2,3 +2,4 @@ node_modules
 .env
 .git
 trash
+coverage

.travis.yml

@@ -8,7 +8,8 @@ before_install:
 - git rev-parse HEAD > ./commit.txt
 script:
 - npm install
-- npm run pretest
+- npm run test
+- npm run coverage
 - docker build -t heroku-dockerize:travis .
 - docker images
 deploy:

Dockerfile

@@ -3,6 +3,7 @@ FROM node:14-alpine
 RUN apk add --no-cache --update curl bash
 WORKDIR /app
 
+ARG NODE_ENV=development
 ARG PORT=3000
 ENV PORT=$PORT
 

README.md

@@ -1,3 +1,3 @@
 # Heroku Dockerize
 
-[![Build Status](https://travis-ci.org/ankitjain28may/heroku-dockerize.svg?branch=master)](https://travis-ci.org/ankitjain28may/heroku-dockerize) [![CircleCI](https://circleci.com/gh/ankitjain28may/heroku-dockerize.svg?style=svg)](https://circleci.com/gh/ankitjain28may/heroku-dockerize)
+[![Build Status](https://travis-ci.org/ankitjain28may/heroku-dockerize.svg?branch=master)](https://travis-ci.org/ankitjain28may/heroku-dockerize) [![CircleCI](https://circleci.com/gh/ankitjain28may/heroku-dockerize.svg?style=svg)](https://circleci.com/gh/ankitjain28may/heroku-dockerize) [![codecov](https://codecov.io/gh/ankitjain28may/heroku-dockerize/branch/master/graph/badge.svg?token=9hF1I1wBxl)](https://codecov.io/gh/ankitjain28may/heroku-dockerize)

docker-compose.yml

@@ -5,8 +5,12 @@ networks:
 
 services:
   web:
-    build: .
+    build:
+      context: .
+      args:
+        - NODE_ENV=production
     container_name: heroku-dockerize-web
+
     networks:
       - internal
     ports:

heroku.yml

@@ -9,5 +9,7 @@ setup:
 build:
   docker:
     web: Dockerfile
+  config:
+    NODE_ENV: production
 run:
   web: node index.js

index.js

@@ -4,7 +4,6 @@ const redis = require('redis')
 const path = require('path')
 const app = express()
 
-const port = process.env.PORT || 3000
 const redisUrl = process.env.REDIS_URL || 'redis://localhost:6379'
 const client = redis.createClient(redisUrl)
 
@@ -50,4 +49,17 @@ app.post('/dummy/:id', (req, res) => {
   })
 })
 
-app.listen(port, () => console.log(`Example app listening at http://localhost:${port}`))
+app.delete('/dummy/:id', (req, res) => {
+  client.del(req.params.id, (err, reply) => {
+    if (err) {
+      return res.send(err)
+    }
+    if (reply === 1) {
+      return res.send('Deleted Successfully!')
+    } else {
+      return res.send('Cannot delete')
+    }
+  })
+})
+
+module.exports = app