Skip to content

Commit

Permalink
[frontend] update idls and ensure thrift fields roundtrip (uber#5365)
Browse files Browse the repository at this point in the history
* [frontend] update ilds and ensure thrift fields roundtrip

* update idls submodule

* regenerate using proper go version 1.17
  • Loading branch information
3vilhamster authored Jul 28, 2023
1 parent 6961e8e commit 553c95e
Show file tree
Hide file tree
Showing 4 changed files with 192 additions and 21 deletions.
136 changes: 132 additions & 4 deletions .gen/go/shared/shared.go

Large diffs are not rendered by default.

36 changes: 20 additions & 16 deletions common/types/mapper/thrift/shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -6266,6 +6266,8 @@ func FromWorkflowExecutionInfo(t *types.WorkflowExecutionInfo) *shared.WorkflowE
CloseStatus: FromWorkflowExecutionCloseStatus(t.CloseStatus),
HistoryLength: &t.HistoryLength,
ParentDomainId: t.ParentDomainID,
ParentDomainName: t.ParentDomain,
ParentInitatedId: t.ParentInitiatedID,
ParentExecution: FromWorkflowExecution(t.ParentExecution),
ExecutionTime: t.ExecutionTime,
Memo: FromMemo(t.Memo),
Expand All @@ -6284,22 +6286,24 @@ func ToWorkflowExecutionInfo(t *shared.WorkflowExecutionInfo) *types.WorkflowExe
return nil
}
return &types.WorkflowExecutionInfo{
Execution: ToWorkflowExecution(t.Execution),
Type: ToWorkflowType(t.Type),
StartTime: t.StartTime,
CloseTime: t.CloseTime,
CloseStatus: ToWorkflowExecutionCloseStatus(t.CloseStatus),
HistoryLength: t.GetHistoryLength(),
ParentDomainID: t.ParentDomainId,
ParentExecution: ToWorkflowExecution(t.ParentExecution),
ExecutionTime: t.ExecutionTime,
Memo: ToMemo(t.Memo),
SearchAttributes: ToSearchAttributes(t.SearchAttributes),
AutoResetPoints: ToResetPoints(t.AutoResetPoints),
TaskList: t.GetTaskList(),
IsCron: t.GetIsCron(),
UpdateTime: t.UpdateTime,
PartitionConfig: t.PartitionConfig,
Execution: ToWorkflowExecution(t.Execution),
Type: ToWorkflowType(t.Type),
StartTime: t.StartTime,
CloseTime: t.CloseTime,
CloseStatus: ToWorkflowExecutionCloseStatus(t.CloseStatus),
HistoryLength: t.GetHistoryLength(),
ParentDomainID: t.ParentDomainId,
ParentDomain: t.ParentDomainName,
ParentInitiatedID: t.ParentInitatedId,
ParentExecution: ToWorkflowExecution(t.ParentExecution),
ExecutionTime: t.ExecutionTime,
Memo: ToMemo(t.Memo),
SearchAttributes: ToSearchAttributes(t.SearchAttributes),
AutoResetPoints: ToResetPoints(t.AutoResetPoints),
TaskList: t.GetTaskList(),
IsCron: t.GetIsCron(),
UpdateTime: t.UpdateTime,
PartitionConfig: t.PartitionConfig,
}
}

Expand Down
39 changes: 39 additions & 0 deletions common/types/mapper/thrift/shared_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// The MIT License (MIT)

// Copyright (c) 2017-2020 Uber Technologies Inc.

// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

package thrift_test

import (
"testing"

"github.com/stretchr/testify/assert"

"github.com/uber/cadence/common/types"
"github.com/uber/cadence/common/types/mapper/thrift"
"github.com/uber/cadence/common/types/testdata"
)

func TestWorkflowExecutionInfo(t *testing.T) {
for _, item := range []*types.WorkflowExecutionInfo{nil, {}, &testdata.WorkflowExecutionInfo, &testdata.CronWorkflowExecutionInfo} {
assert.Equal(t, item, thrift.ToWorkflowExecutionInfo(thrift.FromWorkflowExecutionInfo(item)))
}
}
2 changes: 1 addition & 1 deletion idls
Submodule idls updated 1 files
+2 −0 thrift/shared.thrift

0 comments on commit 553c95e

Please sign in to comment.