-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New JS API for bury & suspend card and bury & suspend note and tag card #9245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like this idea a lot but we need to kill the boilerplate on it first thing, before a lot of these go in. I asked for advice there
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The combined change looks great (that is: implementing the feature, but with @JavascriptInterface
Thank you guys so much! |
Pull Request template
Purpose / Description
This continuation of JS API PR to add more functionality and new features to JS API.
Fixes
Fixes #9231
Approach
Added functions to JavaScriptInterface
How Has This Been Tested?
Use following functions for the API
return boolean
)return boolean
)return boolean
)return boolean
)void function
)Tested on devices and emulator
Learning (optional, can help others)
https://github.com/ankidroid/Anki-Android/wiki/AnkiDroid-Javascript-API
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
if
statements)