Skip to content

Comments

Convert MissingImageHandler to static#7195

Merged
mikehardy merged 1 commit intoankidroid:masterfrom
david-allison:7174-no-image-warning
Sep 21, 2020
Merged

Convert MissingImageHandler to static#7195
mikehardy merged 1 commit intoankidroid:masterfrom
david-allison:7174-no-image-warning

Conversation

@david-allison
Copy link
Member

Purpose / Description

We warned a user once per deck about missing images, this was annoying to them as the missing images were intentional.

We only want to warn the user once per application session

Fixes

Fixes #7174

Approach

Make the variable static - enforced to be the application lifetime.

How Has This Been Tested?

Tested on my Android 9

Learning

We're creeping closer to a time where DI would have benefits.

Checklist

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code

We only want to warn the user once per application session

Fixes 7174
@david-allison david-allison added this to the 2.13.3 release milestone Sep 21, 2020
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy mikehardy merged commit 30034cf into ankidroid:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Option to disable missing media error message.

2 participants