-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show options menu & navigation drawer using WebView #6387
Conversation
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java
This will be useful if AnkiDroid is in fullscreen, then one can be added to open those menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, then good to go!
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java Updated AbstractFlashcardViewer.java
…Android into feature-branch-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty soon people will be able to have whatever user interface they want, at least with review :-). LGTM, thanks @infinyte7
Pull Request template
Purpose / Description
Show options menu using JavaScript in WebView when screen is in fullscreen.
This is continuation of #6307
Fixes
Fixes Link to the issues.
Approach
How Has This Been Tested?
Tested on Emulator
<script>
tagLearning (optional, can help others)
https://stackoverflow.com/questions/32643310/getactionbar-returns-null-in-actionbar
https://stackoverflow.com/questions/4642914/is-there-a-way-to-determine-if-android-app-is-running-full-screen
Checklist
Please, go through these checks before submitting the PR.
if
statements)