Improve the review forgotten cards dialog

[nourhanbakry]

Purpose / Description

Improve the "Review forgotten cards" dialog.

The current dialog has multiple UX issues:

• unclear title
• unnecessary text like "x days" in description
• no unit shown in input field
• generic "OK" button label
• no inline validation feedback
• shows error dialog instead of inline warning when no cards match

This creates confusion and breaks consistency with other dialogs.

Fixes

• Fixes Improve the Review forgotten cards dialog #20598

Approach

The dialog UI and behavior were updated to match the expected UX:

• added a clear title "Review forgotten cards"
• removed redundant "x days" text from description
• added dynamic unit suffix "day/days" to the input field using getQuantityString
• changed positive button text from "OK" to "Create"

Validation improvements:

• prevented leading zeros using InputFilter
• limited input length
• disabled button when input is invalid or zero
• added inline error messages instead of showing a dialog

Dynamic validation:

• on each input change, a background check runs using hasMatchingCards
• if no cards match the criteria:
  • show error message "No cards matched the criteria"
  • disable the button
• if valid:
  • clear error
  • enable button

This ensures immediate feedback without interrupting the user flow.

How Has This Been Tested?

Tested manually with the following setup:

• Device: Pixel 8 emulator
• API Level: 36
• Build Variant: playDebug

Screen.Recording.2026-03-29.at.2.30.25.AM.mov

Checklist

Please, go through these checks before submitting the PR.

• [✅] You have a descriptive commit message with a short title (first line, max 50 chars).
• [✅] You have commented your code, particularly in hard-to-understand areas
• [✅] You have performed a self-review of your own code
• [✅] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [✅] UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Important

Maintainers: This PR contains Strings changes

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

[david-allison]

Failing lint

https://github.com/ankidroid/Anki-Android/tree/main/.github/workflows#quality-checks

[Galal-20]

Hello @nourhanbakry
If the resource ("Invalid number") is really not needed, remove it.

[nourhanbakry]

Hello @nourhanbakry If the resource ("Invalid number") is really not needed, remove it.

Thanks for your comment, I fixed it

[DoomsCoder]

Same issue here as well : see this comment #20618 (comment)

[DoomsCoder]

You can use TR.customStudyNoCardsMatchedTheCriteriaYou instead of the string resource here to avoid duplication

[david-allison]

This is taking on too much, please fix the commit structure via rebase + force push so individual changes are reviewable as separate commits or split out maybe 2 smaller PRs so they're reviewable

This feels AI-genned, could I confirm it's not? The use of bare strings, where your previews PRs contained R.string seemed unusual

https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md