Skip to content

Improve dialog UI consistency and readability across multiple dialogs#20553

Open
Galal-20 wants to merge 8 commits intoankidroid:mainfrom
Galal-20:Improve-some-dialogs(Set-due-date-Change-note-type)
Open

Improve dialog UI consistency and readability across multiple dialogs#20553
Galal-20 wants to merge 8 commits intoankidroid:mainfrom
Galal-20:Improve-some-dialogs(Set-due-date-Change-note-type)

Conversation

@Galal-20
Copy link
Copy Markdown
Contributor

Purpose / Description

This PR improves dialog UI consistency and readability across multiple dialogs, specifically Set due date and Change note type.

Fixes

Fixes: Improve some dialogs (mostly string changes) #20508

Approach

Set due date dialog:
• Added text labels to tab icons to improve clarity and usability.
• Replaced the “Help” text with a question mark icon in the top-right corner to align with other dialogs.
Change note type dialog:
• Updated tab text and icon colors to match the styling used in the “Set due date” dialog for consistency.
• Improved cloze note type colors to ensure better readability, especially in dark mode.

How Has This Been Tested?

Tested on Android emulator and physical device.
Verified behavior in both light and dark themes.
Checked:
• Tab selection states (selected/unselected colors)
• Visibility and readability of cloze note types
• Icon and text alignment in tabs

2 3 4 1

Checklist

  • Descriptive commit message with short title.
  • Code is commented in tricky areas.
  • Self-reviewed changes.
  • UI changes screenshots captured (dialogs, buttons, labels).
  • Tested with Accessibility Scanner to ensure text readability.

Set due date:
- Add text to tab icons
- Replace "Help" text with a question mark icon in the upper right corner

Change note type:
- Update tab text and icon colors
- Improve cloze note type colors
@github-actions
Copy link
Copy Markdown
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

The text and icons should either be on the same line or on two lines in both the set due date and change note type dialogs. I prefer the 2 line look in the set due date dialog screenshot.


The cloze color is certainly an improvement, but I still feel it's a little bit difficult to read.

In comparison, the light theme is too bright and the black theme is readable but not different enough from white:

ResizedImage_2026-03-23_06-29-32_9419
Btw...

I noticed that the dropdown menu's width depends on the height of the dialog (and thus the number of fields):

ResizedImage_2026-03-23_06-30-54_1299

You don't have to do it, and if it isn't easily fixable, then leave it.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Mar 23, 2026
… for consistency with 'Set Due Date' dialog.

- Improve Cloze note type color visibility for better readability in the note type spinner.
- Ensure Spinner dropdown width is stable by setting a minimum width and proper layout weights, preventing it from collapsing when the dialog height changes.
@Galal-20
Copy link
Copy Markdown
Contributor Author

Hi @ZornHadNoChoice, I've addressed the requested changes.
Would appreciate another look when you have time.
Thanks.

@ZornHadNoChoice

This comment was marked as resolved.

@Galal-20
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback
I've updated the screenshots to reflect the latest changes.
Please let me know if anything else needs adjustment.
I'm trying to do my best.

1 2 3 4

@david-allison
Copy link
Copy Markdown
Member

david-allison commented Mar 25, 2026

Looks great!

Having the text underneath the icon for the 'manage note types' dialog makes the screen appear like there are 2 columns all the way down.

There needs to be a more prominent 'divider' between the tab views and the content if we're using vertical labels (I personally prefer horizontal labels here)


Add maybe 8dp more end padding after Basic (and optional reversed), the indicator for selection looks a little too close to the text

Screenshot 2026-03-25 at 13 55 31

Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks solid!

The text and icons should either be on the same line or on two lines in both the set due date and change note type dialogs. I prefer the 2 line look in the set due date dialog screenshot.

-- Zorn

I'd use the vertical icons in 'Set Due Date', and continue with the horizontal icon with text in 'fields'

@ZornHadNoChoice @Haz3-jolt what do you think here? I don't like how the screen looks like two columns throughout if the text is vertically stacked

Image Image

@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

ZornHadNoChoice commented Mar 25, 2026

I also don't like the column feel. I guess a slight inconsistency doesn't hurt.

If we're going to nitpick: the text in the current column has a slightly bigger font than the text in the new column.

Also, is there any reason the "pen" icon was used for fields? See https://fonts.google.com/icons?icon.query=field

@david-allison
Copy link
Copy Markdown
Member

Also, is there any reason the "pen" icon was used for fields? See https://fonts.google.com/icons?icon.query=field

I don't think 'text fields' is a good icon.

Do you like Text Fields Alt?

@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

ZornHadNoChoice commented Mar 25, 2026

It isn't perfect, but at least it's not just the edit icon. What do you think about the Wysiwyg icon?

@Haz3-jolt
Copy link
Copy Markdown
Member

I prefer the icon to the side instead of on top, it looks off.

@ZornHadNoChoice
Copy link
Copy Markdown
Collaborator

For horizontal icons, wouldn't it be better if they were on the left?

@Haz3-jolt
Copy link
Copy Markdown
Member

Oh nice suggestion, I agree

@david-allison
Copy link
Copy Markdown
Member

You're right, I think icon before would look better

Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab headings seem incorrect (change note type should not be vertical). The styling of the text also seems inconsistent

AnkiDroid Version = 2.24.0alpha11-debug (f67aa821e7e37abaf92d5247e875783102b363d4)  
Backend Version = 0.1.63-anki25.09.2 (25.09.2 3890e12c9e48c028c3f12aa58cb64bd9f8895e30)  
Android Version = 13 (SDK 33)  
ProductFlavor = full  
Device Info = Google | google | emu64a | sdk_gphone64_arm64 | sdk_gphone64_arm64 | ranchu  
WebView Info = [com.google.android.webview | 541412334]: Mozilla/5.0 (Linux; Android 13; sdk_gphone64_arm64 Build/TE1A.240213.009; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/109.0.5414.123 Mobile Safari/537.36  
ACRA UUID = 3fe2f7ab-71d7-4e71-aa22-e7c451a95beb  
FSRS = 5.1.0 (Enabled: false)  
Crash Reports Enabled = false
Screenshot 2026-03-27 at 23 14 00 Screenshot 2026-03-27 at 23 14 09

@Galal-20
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @david-allison.

I’ve updated the tab layout to avoid the vertical appearance and ensured that text and icons are displayed consistently. I also aligned the styling with the existing dialogs to keep the UI uniform across the app.

Please let me know if this looks correct now.

@Galal-20 Galal-20 requested a review from david-allison March 28, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has Conflicts Needs Author Reply Waiting for a reply from the original author Needs Review Strings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants