Improve dialog UI consistency and readability across multiple dialogs#20553
Improve dialog UI consistency and readability across multiple dialogs#20553Galal-20 wants to merge 8 commits intoankidroid:mainfrom
Conversation
Set due date: - Add text to tab icons - Replace "Help" text with a question mark icon in the upper right corner Change note type: - Update tab text and icon colors - Improve cloze note type colors
|
Important Maintainers: This PR contains Strings changes
|
… for consistency with 'Set Due Date' dialog. - Improve Cloze note type color visibility for better readability in the note type spinner. - Ensure Spinner dropdown width is stable by setting a minimum width and proper layout weights, preventing it from collapsing when the dialog height changes.
|
Hi @ZornHadNoChoice, I've addressed the requested changes. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
All looks solid!
The text and icons should either be on the same line or on two lines in both the set due date and change note type dialogs. I prefer the 2 line look in the set due date dialog screenshot.
-- Zorn
I'd use the vertical icons in 'Set Due Date', and continue with the horizontal icon with text in 'fields'
@ZornHadNoChoice @Haz3-jolt what do you think here? I don't like how the screen looks like two columns throughout if the text is vertically stacked
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
|
I also don't like the column feel. I guess a slight inconsistency doesn't hurt. If we're going to nitpick: the text in the current column has a slightly bigger font than the text in the new column. Also, is there any reason the "pen" icon was used for fields? See https://fonts.google.com/icons?icon.query=field |
I don't think 'text fields' is a good icon. Do you like Text Fields Alt? |
|
It isn't perfect, but at least it's not just the edit icon. What do you think about the Wysiwyg icon? |
|
I prefer the icon to the side instead of on top, it looks off. |
|
For horizontal icons, wouldn't it be better if they were on the left? |
|
Oh nice suggestion, I agree |
|
You're right, I think icon before would look better |
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The tab headings seem incorrect (change note type should not be vertical). The styling of the text also seems inconsistent
AnkiDroid Version = 2.24.0alpha11-debug (f67aa821e7e37abaf92d5247e875783102b363d4)
Backend Version = 0.1.63-anki25.09.2 (25.09.2 3890e12c9e48c028c3f12aa58cb64bd9f8895e30)
Android Version = 13 (SDK 33)
ProductFlavor = full
Device Info = Google | google | emu64a | sdk_gphone64_arm64 | sdk_gphone64_arm64 | ranchu
WebView Info = [com.google.android.webview | 541412334]: Mozilla/5.0 (Linux; Android 13; sdk_gphone64_arm64 Build/TE1A.240213.009; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/109.0.5414.123 Mobile Safari/537.36
ACRA UUID = 3fe2f7ab-71d7-4e71-aa22-e7c451a95beb
FSRS = 5.1.0 (Enabled: false)
Crash Reports Enabled = false
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback @david-allison. I’ve updated the tab layout to avoid the vertical appearance and ensured that text and icons are displayed consistently. I also aligned the styling with the existing dialogs to keep the UI uniform across the app. Please let me know if this looks correct now. |







Purpose / Description
This PR improves dialog UI consistency and readability across multiple dialogs, specifically Set due date and Change note type.
Fixes
Fixes: Improve some dialogs (mostly string changes) #20508
Approach
Set due date dialog:
• Added text labels to tab icons to improve clarity and usability.
• Replaced the “Help” text with a question mark icon in the top-right corner to align with other dialogs.
Change note type dialog:
• Updated tab text and icon colors to match the styling used in the “Set due date” dialog for consistency.
• Improved cloze note type colors to ensure better readability, especially in dark mode.
How Has This Been Tested?
Tested on Android emulator and physical device.
Verified behavior in both light and dark themes.
Checked:
• Tab selection states (selected/unselected colors)
• Visibility and readability of cloze note types
• Icon and text alignment in tabs
Checklist