fix: minor Android Studio warnings#20412
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
ea74373 to
325cb50
Compare
|
@aadityarshah It is not a review. But you do not have to omit items that are not ticked in the checklist. Also, have you noticed that it has failed Unit Tests? |
|
@Alok-Silswal Thank you for notifying me about the fact that we do not have to omit items that are not ticked in the checklist. |
|
If this PR is not complete, then you may mark this as a draft for the meantime. |
|
@Alok-Silswal okay thank you for your advice, I will convert to draft. |
|
@david-allison Thank you sir! I have opened the pull request since it was a draft earlier. Can you see if you can merge it now? |
|
I can't reproduce the CI issue, but it looks persistent, could you split the change into separate commits so you can figure out which change is causing the CI break? We can get the others in without issue. |
325cb50 to
c912daf
Compare
|
@david-allison I have separated each of the commits as you suggested, thank you for your advice! |
|
Which one broke CI? You can test using GitHub Actions on your fork |
aefb3d1 to
b802430
Compare
|
@david-allison On reviewing each of the commits individually using Github Actions, I found out that the change I was trying to make by adding package for |
|
Before I merge this
Cheers! |
b802430 to
66a479d
Compare
|
@david-allison I didn't notice that, I am sorry for that. Thank you for informing, I have updated those fields after deciding to keep my email private. Can you check the updates and see if you can merge it now? |
fix: Changed PermissionDenied from inner class to class fix: Fixed spacing in `@Ignore` message fix: Added missing package declaration to Utils.kt
66a479d to
b2b0023
Compare
|
Thanks so much!! |
Purpose / Description
As a new contributor, I wanted to get familiar with the codebase and wanted to have my first pull request merged. Fixes #13282 seemed to be a good starting point and hence, I decided to fix some Android Studio warnings.
Fixes
AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt)Approach
Ran
Code/Inspect Codein Android Studio and reviewed the warnings/problems in the code and made the following changes:CardBrowserTest.ktin the directoryAnkiDroid/src/test/java/com/ichi2/anki, added a space between 'current' and 'use' since it was a problem in the fileUtils.ktin the directoryAnkiDroid/src/main/java/com/ichi2/anki/dialogs, added thepackage com.ichi2.anki ...line to resolve the warning "Package directive does not match the file location"Test21And26.ktin the directoryAnkiDroid/src/test/java/com/ichi2/compat, removed the redundantinnercall on the classPermissionDenied.How Has This Been Tested?
:AnkiDroidmodule to an emulator which ran successfullyChecklist
Please, go through these checks before submitting the PR.