Skip to content

Cleanup: fixed some warnings #20344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tejasM17 wants to merge 4 commits into from
+6 −7
Closed

Cleanup: fixed some warnings #20344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caee37c
Fix warning in registering back callback on api 33+
tejasM17 Feb 20, 2026
ebf6f70
Cleanup: fix layout reference from axis_display to view_axis_display …
tejasM17 Feb 20, 2026
3dd2a2f
Cleanup: fix Removed redundant qualifier name warning
tejasM17 Feb 20, 2026
5afb45d
Cleanup: Fix prefs is never used
tejasM17 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/android/back/ExitViaDoubleTapBackBackPressCallback.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fun AnkiActivity.exitViaDoubleTapBackCallback(): OnBackPressedCallback =
// PreferenceManager uses weak references, so we need our own strong reference which
// will go out of scope
callback.strongListenerReference =
OnSharedPreferenceChangeListener { prefs, key ->
OnSharedPreferenceChangeListener { _, key ->
if (key == getString(R.string.exit_via_double_tap_back_key)) {
callback.isEnabled =
Prefs.exitViaDoubleTapBack.also {
Expand Down
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/ui/AppCompatPreferenceActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ abstract class AppCompatPreferenceActivity<PreferenceHack : AppCompatPreferenceA
// HACK: PreferenceActivity does not have a back dispatcher
// on API <= 32, onKeyDown is called; on API 33+, this is needed
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
getOnBackInvokedDispatcher().registerOnBackInvokedCallback(PRIORITY_OVERLAY) {
onBackInvokedDispatcher.registerOnBackInvokedCallback(PRIORITY_OVERLAY) {
tryCloseWithResult()
}
}
Expand Down
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/ui/AxisSelector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import timber.log.Timber
* - If an [extremity][AxisValueDisplay.isExtremity] is reached, these are activated
* - Calls [onExtremitySelectedListener] if tapped
*
* @see R.layout.axis_display
* @see R.layout.view_axis_display
* @see AxisValueDisplay
*/
class AxisSelector : LinearLayout {
Expand Down
7 changes: 3 additions & 4 deletions AnkiDroid/src/main/java/com/ichi2/ui/GestureDisplay.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import android.util.AttributeSet
import android.view.GestureDetector
import android.view.LayoutInflater
import android.view.MotionEvent
import android.view.View
import android.widget.ImageView
import androidx.constraintlayout.widget.ConstraintLayout
import com.ichi2.anki.cardviewer.Gesture
Expand Down Expand Up @@ -122,7 +121,7 @@ class GestureDisplay
}

/**
* Sets the "swipe" view to the provided swipe (or none if the gesture is null or non-swipe])
* Sets the "swipe" view to the provided swipe (or none if the gesture is null or non-swipe)
* Only works on API 25+ due to issues with layer-list
*/
private fun handleSwipeChange(gesture: Gesture?) {
Expand Down Expand Up @@ -174,8 +173,8 @@ class GestureDisplay
private fun setTapGestureMode(tapGestureMode: TapGestureMode) {
val ninePointVisibility =
when (tapGestureMode) {
TapGestureMode.FOUR_POINT -> View.GONE
TapGestureMode.NINE_POINT -> View.VISIBLE
TapGestureMode.FOUR_POINT -> GONE
TapGestureMode.NINE_POINT -> VISIBLE
}

NINE_POINT_TAP_GESTURES.forEach { gesture ->
Expand Down
Loading