Skip to content

Comments

refactor: remove merge from toolbar.xml#20286

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:binding-toolbar
Feb 3, 2026
Merged

refactor: remove merge from toolbar.xml#20286
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:binding-toolbar

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Feb 1, 2026

It's not needed (we already have a single view as root and we don't append this included layout to a Toolbar view)

It also breaks ViewBinding: "Missing required view with ID: com.ichi2.anki.debug:id/toolbar".

Fixes

How Has This Been Tested?

Tablet emulator (API 33):

  • Reviewer
  • Deck Picker
  • Note Editor
  • Card Browser Appearance
  • Info
  • Note Field Editor
  • Study Options

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

It's not needed (we already have a single view as root and we
 don't append this included layout to a Toolbar view)

It also breaks ViewBinding: "Missing required view with ID: `com.ichi2.anki.debug:id/toolbar`".

Issue 11116
@david-allison david-allison mentioned this pull request Feb 2, 2026
92 tasks
@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 2, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Feb 3, 2026
Merged via the queue into ankidroid:main with commit f690066 Feb 3, 2026
19 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Feb 3, 2026
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants