Skip to content

Comments

chore: convert AllPermissionsExplanationFragment to ViewBinding#20202

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-AllPermissionsExplanationFragment
Jan 24, 2026
Merged

chore: convert AllPermissionsExplanationFragment to ViewBinding#20202
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-AllPermissionsExplanationFragment

Conversation

@david-allison
Copy link
Member

Approach

  • I redid this one from scratch

How Has This Been Tested?

Brief test:

  • Pixel 9 Pro - opened the screen and it looked great!

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Jan 23, 2026
92 tasks
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 23, 2026
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 24, 2026
@lukstbit lukstbit added this pull request to the merge queue Jan 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 24, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 24, 2026
Merged via the queue into ankidroid:main with commit 09e71e3 Jan 24, 2026
19 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 24, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 24, 2026
@david-allison david-allison deleted the vb-AllPermissionsExplanationFragment branch January 24, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants