Skip to content

chore: convert FlagAdapter to ViewBinding #20183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 2 commits into from
Jan 23, 2026
Merged

chore: convert FlagAdapter to ViewBinding #20183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98470b4
chore: convert FlagAdapter to ViewBinding
david-allison Sep 12, 2025
1bc9040
refactor: FlagAdapter - IDE lint
david-allison Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/FlagAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ import androidx.recyclerview.widget.RecyclerView
import com.google.android.material.button.MaterialButton
import com.google.android.material.textfield.TextInputEditText
import com.ichi2.anki.Flag
import com.ichi2.anki.R
import com.ichi2.anki.utils.ext.findViewById
import com.ichi2.anki.databinding.EditFlagItemBinding
import com.ichi2.utils.moveCursorToEnd
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.launch
Expand All @@ -45,27 +44,27 @@ import kotlinx.coroutines.launch
class FlagAdapter(
private val lifecycleScope: CoroutineScope,
) : ListAdapter<FlagItem, FlagAdapter.FlagViewHolder>(FlagItemDiffCallback()) {
inner class FlagViewHolder(
itemView: View,
) : RecyclerView.ViewHolder(itemView) {
val flagImageView: ImageView = findViewById(R.id.ic_flag)
val flagNameText: TextView = findViewById(R.id.flag_name)
val flagNameEdit: TextInputEditText = findViewById(R.id.flag_name_edit_text)
val editButton: MaterialButton = findViewById(R.id.action_edit_flag)
val saveButton: MaterialButton = findViewById(R.id.action_save_flag_name)
val cancelButton: MaterialButton = findViewById(R.id.action_cancel_flag_rename)
class FlagViewHolder(
binding: EditFlagItemBinding,
) : RecyclerView.ViewHolder(binding.root) {
val flagImageView: ImageView = binding.icFlag
val flagNameText: TextView = binding.flagName
val flagNameEdit: TextInputEditText = binding.flagNameEditText
val editButton: MaterialButton = binding.actionEditFlag
val saveButton: MaterialButton = binding.actionSaveFlagName
val cancelButton: MaterialButton = binding.actionCancelFlagRename

val flagNameViewLayout: LinearLayout = findViewById(R.id.flag_name_view_layout)
val flagNameEditLayout: LinearLayout = findViewById(R.id.edit_flag_name_layout)
val flagNameViewLayout: LinearLayout = binding.flagNameViewLayout
val flagNameEditLayout: LinearLayout = binding.editFlagNameLayout
}

override fun onCreateViewHolder(
parent: ViewGroup,
viewType: Int,
): FlagViewHolder {
val view =
LayoutInflater.from(parent.context).inflate(R.layout.edit_flag_item, parent, false)
return FlagViewHolder(view)
val inflater = LayoutInflater.from(parent.context)
val binding = EditFlagItemBinding.inflate(inflater, parent, false)
return FlagViewHolder(binding)
}

override fun onBindViewHolder(
Expand Down
Loading