Skip to content

chore: convert AboutFragment to ViewBinding #20151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 1 commit into from
Jan 21, 2026
Merged

chore: convert AboutFragment to ViewBinding #20151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 16 additions & 33 deletions AnkiDroid/src/main/java/com/ichi2/anki/preferences/AboutFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,14 @@ import android.os.Bundle
import android.text.format.DateFormat
import android.text.method.LinkMovementMethod
import android.view.View
import android.widget.Button
import android.widget.ImageView
import android.widget.TextView
import androidx.appcompat.app.AlertDialog
import androidx.core.text.parseAsHtml
import androidx.fragment.app.Fragment
import com.google.android.material.appbar.MaterialToolbar
import com.ichi2.anki.AnkiDroidApp
import com.ichi2.anki.BuildConfig
import com.ichi2.anki.Info
import com.ichi2.anki.R
import com.ichi2.anki.databinding.AboutLayoutBinding
import com.ichi2.anki.launchCatchingTask
import com.ichi2.anki.requireAnkiActivity
import com.ichi2.anki.scheduling.Fsrs
Expand All @@ -42,6 +39,7 @@ import com.ichi2.utils.IntentUtil
import com.ichi2.utils.VersionUtils.pkgVersionName
import com.ichi2.utils.copyToClipboard
import com.ichi2.utils.show
import dev.androidbroadcast.vbpd.viewBinding
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import java.text.SimpleDateFormat
Expand All @@ -50,42 +48,32 @@ import java.util.Locale
import net.ankiweb.rsdroid.BuildConfig as BackendBuildConfig

class AboutFragment : Fragment(R.layout.about_layout) {
private val binding by viewBinding(AboutLayoutBinding::bind)

override fun onViewCreated(
view: View,
savedInstanceState: Bundle?,
) {
view.findViewById<MaterialToolbar>(R.id.toolbar).apply {
setNavigationOnClickListener { requireActivity().onBackPressedDispatcher.onBackPressed() }
}
binding.toolbar.setNavigationOnClickListener { requireActivity().onBackPressedDispatcher.onBackPressed() }

// Version date
val apkBuildDate =
binding.buildDate.text =
SimpleDateFormat(DateFormat.getBestDateTimePattern(Locale.getDefault(), "d MMM yyyy"))
.format(Date(BuildConfig.BUILD_TIME))
view.findViewById<TextView>(R.id.about_build_date).text = apkBuildDate

// Version text
view.findViewById<TextView>(R.id.about_version).text =
pkgVersionName

// Backend version text
view.findViewById<TextView>(R.id.about_backend).text =
binding.version.text = pkgVersionName
binding.backendVersion.text =
"(anki " + BackendBuildConfig.ANKI_DESKTOP_VERSION + " / " + BackendBuildConfig.ANKI_COMMIT_HASH.subSequence(0, 8) + ")"

// FSRS version text
view.findViewById<TextView>(R.id.about_fsrs).text = Fsrs.displayVersion ?.let { version ->
binding.fsrsVersion.text = Fsrs.displayVersion ?.let { version ->
"($version)"
} ?: ""

// Logo secret
view
.findViewById<ImageView>(R.id.about_app_logo)
.setOnClickListener(DevOptionsSecretClickListener(this))
binding.appLogo.setOnClickListener(DevOptionsSecretClickListener(this))

// Contributors text
val contributorsLink = getString(R.string.link_contributors)
val contributingGuideLink = getString(R.string.link_contribution)
view.findViewById<TextView>(R.id.about_contributors_description).apply {
binding.contributorsDescription.apply {
text = getString(R.string.about_contributors_description, contributorsLink, contributingGuideLink).parseAsHtml()
movementMethod = LinkMovementMethod.getInstance()
}
Expand All @@ -95,7 +83,7 @@ class AboutFragment : Fragment(R.layout.about_layout) {
val agplLicenseLink = getString(R.string.link_agpl_wiki)
val sourceCodeLink = getString(R.string.link_source)
val dependencyLicenseLink = getString(R.string.dependency_license_wiki)
view.findViewById<TextView>(R.id.about_license_description).apply {
binding.licenseDescription.apply {
text =
(
getString(R.string.license_description, gplLicenseLink, agplLicenseLink, sourceCodeLink) + "<br>" +
Expand All @@ -106,29 +94,24 @@ class AboutFragment : Fragment(R.layout.about_layout) {

// Donate text
val donateLink = getString(R.string.link_opencollective_donate)
view.findViewById<TextView>(R.id.about_donate_description).apply {
binding.donateDescription.apply {
text = getString(R.string.donate_description, donateLink).parseAsHtml()
movementMethod = LinkMovementMethod.getInstance()
}

// Rate Ankidroid button
view.findViewById<Button>(R.id.about_rate).setOnClickListener {
binding.rateAnkiDroid.setOnClickListener {
IntentUtil.tryOpenIntent(requireAnkiActivity(), AnkiDroidApp.getMarketIntent(requireContext()))
}

// Open changelog button
view.findViewById<Button>(R.id.about_open_changelog).setOnClickListener {
binding.openChangelog.setOnClickListener {
val openChangelogIntent =
Intent(requireContext(), Info::class.java).apply {
putExtra(Info.TYPE_EXTRA, Info.TYPE_NEW_VERSION)
}
startActivity(openChangelogIntent)
}

// Copy debug info button
view.findViewById<Button>(R.id.about_copy_debug).setOnClickListener {
copyDebugInfo()
}
binding.copyDebugInfo.setOnClickListener { copyDebugInfo() }
}

/**
Expand Down
22 changes: 11 additions & 11 deletions AnkiDroid/src/main/res/layout/about_layout.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
android:paddingHorizontal="12dp">

<ImageView
android:id="@+id/about_app_logo"
android:id="@+id/app_logo"
android:layout_width="96dp"
android:layout_height="96dp"
app:srcCompat="@drawable/ankidroid_logo" />
Expand All @@ -66,29 +66,29 @@
app:tint="?android:attr/textColor" />

<TextView
android:id="@+id/about_version"
android:id="@+id/version"
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="4dp"
tools:text="2.x" />

<TextView
android:id="@+id/about_build_date"
android:id="@+id/build_date"
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
tools:text="13 Apr 2023" />

<TextView
android:id="@+id/about_backend"
android:id="@+id/backend_version"
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
tools:text="(anki 23.10.1 / be74babb0)" />

<TextView
android:id="@+id/about_fsrs"
android:id="@+id/fsrs_version"
style="?android:textAppearanceSmall"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
Expand All @@ -104,7 +104,7 @@
android:textSize="16sp" />

<TextView
android:id="@+id/about_contributors_description"
android:id="@+id/contributors_description"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginVertical="4dp"
Expand All @@ -122,7 +122,7 @@
android:textSize="16sp" />

<TextView
android:id="@+id/about_license_description"
android:id="@+id/license_description"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginVertical="4dp"
Expand All @@ -139,7 +139,7 @@
android:textSize="16sp" />

<TextView
android:id="@+id/about_donate_description"
android:id="@+id/donate_description"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginVertical="4dp"
Expand All @@ -153,21 +153,21 @@
android:orientation="vertical"
android:gravity="center">
<com.google.android.material.button.MaterialButton
android:id="@+id/about_rate"
android:id="@+id/rate_anki_droid"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/info_rate"
style="@style/Widget.Material3.Button.TextButton"
android:textColor="?attr/colorAccent" />
<com.google.android.material.button.MaterialButton
android:id="@+id/about_open_changelog"
android:id="@+id/open_changelog"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/open_changelog"
style="@style/Widget.Material3.Button.TextButton"
android:textColor="?attr/colorAccent"/>
<com.google.android.material.button.MaterialButton
android:id="@+id/about_copy_debug"
android:id="@+id/copy_debug_info"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/feedback_copy_debug"
Expand Down