fix(SharedDecks): Fix freeze when cancelling download#20082
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Jan 15, 2026
Merged
fix(SharedDecks): Fix freeze when cancelling download#20082BrayanDSO merged 1 commit intoankidroid:mainfrom
BrayanDSO merged 1 commit intoankidroid:mainfrom
Conversation
Use popBackStack() instead of onBackPressed() to properly close the fragment. Fixes ankidroid#20077
Member
|
Cheers!
Why? |
Contributor
Author
In the listener we disable the callback then immediately call onBackPressed. I think the dispatcher doesn't pick up the change fast enough so it ignores the call. popBackStack works better because it just removes the fragment directly. |
david-allison
approved these changes
Jan 12, 2026
david-allison
added
Needs Second Approval
BrayanDSO
approved these changes
Jan 15, 2026
BrayanDSO
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes #20077
The download screen was freezing when I clicked "Cancel" passing "Yes".
It seems
onBackPressed()wasn't reliably closing the screen.Fixes
I replaced
onBackPressed()withpopBackStack(). This makes sure the fragment is removed immediately.Approach
I verified this on the emulator and the freeze is gone.
screen-20260112-113552.2.mp4