chore: convert DeckPickerFloatingActionMenu to ViewBinding#20081
Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom Jan 17, 2026
Merged
chore: convert DeckPickerFloatingActionMenu to ViewBinding#20081BrayanDSO merged 2 commits intoankidroid:mainfrom
BrayanDSO merged 2 commits intoankidroid:mainfrom
Conversation
df40889 to
6a41c18
Compare
Tests were removed as they were brittle Issue 11116
6a41c18 to
c468ae6
Compare
lukstbit
approved these changes
Jan 17, 2026
Member
lukstbit
left a comment
There was a problem hiding this comment.
LGTM
I removed the brittle tests, mocking does not seem feasible, and we should extract the logic.
I'm ok the removal of the tests and adding a new implementation later. We shouldn't be mocking views from the start to test stuff.
BrayanDSO
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
with (binding) {blocks to remove verbosity (animation lines became multi-line)How Has This Been Tested?
Brief test:
Pixel 9 Pro - FAB is still usable
Feel free to block this review on this refactor/reimplementing the tests
Checklist