Skip to content

Comments

chore: convert DeckPickerFloatingActionMenu to ViewBinding#20081

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-DeckPickerFloatingActionMenu
Jan 17, 2026
Merged

chore: convert DeckPickerFloatingActionMenu to ViewBinding#20081
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-DeckPickerFloatingActionMenu

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 12, 2026

Approach

  • Cherry picked david-allison@e782e4d
  • Fixed conflicts
  • Added with (binding) { blocks to remove verbosity (animation lines became multi-line)

How Has This Been Tested?

Brief test:

Pixel 9 Pro - FAB is still usable

⚠️ I removed the brittle tests, mocking does not seem feasible, and we should extract the logic.

Feel free to block this review on this refactor/reimplementing the tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Jan 12, 2026
92 tasks
@david-allison david-allison force-pushed the vb-DeckPickerFloatingActionMenu branch from df40889 to 6a41c18 Compare January 12, 2026 06:22
Tests were removed as they were brittle

Issue 11116
@david-allison david-allison force-pushed the vb-DeckPickerFloatingActionMenu branch from 6a41c18 to c468ae6 Compare January 12, 2026 06:51
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I removed the brittle tests, mocking does not seem feasible, and we should extract the logic.

I'm ok the removal of the tests and adding a new implementation later. We shouldn't be mocking views from the start to test stuff.

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 17, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 17, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 17, 2026
Merged via the queue into ankidroid:main with commit a3ce935 Jan 17, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 17, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants