Skip to content

Comments

chore: convert TagLimitFragment & IncludedExcludedTagsAdapter to ViewBinding#20075

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-IncludedExcludedTagsAdapter
Jan 15, 2026
Merged

chore: convert TagLimitFragment & IncludedExcludedTagsAdapter to ViewBinding#20075
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-IncludedExcludedTagsAdapter

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 12, 2026

Approach

How Has This Been Tested?

⚠️ This screen does not appear to be used in Custom Study (yet)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title chore: convert IncludedExcludedTagsAdapter to ViewBinding chore: convert TagLimitFragment & IncludedExcludedTagsAdapter to ViewBinding Jan 12, 2026
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were used before the push back for the previous implementation.

The adapter is probably not going to be used anymore but I think the fragment could still be useful by retrofitting it to embed the actual tag selection fragment(with two tabs for included/excluded).

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 14, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 15, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 15, 2026
Merged via the queue into ankidroid:main with commit e57cde4 Jan 15, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 15, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants