chore: convert CheckPronunciationFragment to ViewBinding#20011
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Jan 9, 2026
Merged
chore: convert CheckPronunciationFragment to ViewBinding#20011lukstbit merged 1 commit intoankidroid:mainfrom
lukstbit merged 1 commit intoankidroid:mainfrom
Conversation
BrayanDSO
approved these changes
Jan 5, 2026
lukstbit
approved these changes
Jan 9, 2026
|
|
||
| private lateinit var playView: AudioPlayView | ||
| private lateinit var recordView: AudioRecordView | ||
| private val binding by viewBinding(CheckPronunciationFragmentBinding::bind) |
Member
There was a problem hiding this comment.
The lint rule didn't catch the layout name for this fragment, it should be R.layout.fragment_check_pronunciation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
vbpdHow Has This Been Tested?
Brief test:
Fragment loads and a recording can be made (new study screen)
Checklist