Skip to content

Comments

chore: convert CheckPronunciationFragment to ViewBinding#20011

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-CheckPronunciationFragment
Jan 9, 2026
Merged

chore: convert CheckPronunciationFragment to ViewBinding#20011
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-CheckPronunciationFragment

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • API33-ext5 (Medium Tablet)

Fragment loads and a recording can be made (new study screen)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 5, 2026

private lateinit var playView: AudioPlayView
private lateinit var recordView: AudioRecordView
private val binding by viewBinding(CheckPronunciationFragmentBinding::bind)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint rule didn't catch the layout name for this fragment, it should be R.layout.fragment_check_pronunciation.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 9, 2026
@lukstbit lukstbit added this pull request to the merge queue Jan 9, 2026
Merged via the queue into ankidroid:main with commit 5d8129f Jan 9, 2026
18 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 9, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants