refactor: remove DeckDropDownAdapter#19899
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Dec 22, 2025
Merged
Conversation
lukstbit
requested changes
Dec 22, 2025
Member
lukstbit
left a comment
There was a problem hiding this comment.
This class, DeckDropDownAdapter, is unused and should be removed(my fault because I didn't see this when removing the toolbar deck selection Spinner).
The only thing keeping it alive is the inner SubtitleProvider interface which is used in CardBrowser but that usage can be removed by using the numberOfCardsOrNoteShown property directly instead of deckDropDownSubtitle from the interface.
df7e7d4 to
cfbcea6
Compare
lukstbit
approved these changes
Dec 22, 2025
cfbcea6 to
ff94a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused
Checklist