Skip to content

Comments

refactor: remove DeckDropDownAdapter#19899

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-DeckDropDownAdapter
Dec 22, 2025
Merged

refactor: remove DeckDropDownAdapter#19899
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-DeckDropDownAdapter

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Dec 22, 2025

Unused

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class, DeckDropDownAdapter, is unused and should be removed(my fault because I didn't see this when removing the toolbar deck selection Spinner).

The only thing keeping it alive is the inner SubtitleProvider interface which is used in CardBrowser but that usage can be removed by using the numberOfCardsOrNoteShown property directly instead of deckDropDownSubtitle from the interface.

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Dec 22, 2025
@david-allison david-allison changed the title chore: convert DeckDropDownAdapter to ViewBinding refactor: remove DeckDropDownAdapter Dec 22, 2025
@david-allison david-allison added Needs Review and removed Priority-Low Needs Author Reply Waiting for a reply from the original author labels Dec 22, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Edit: Still more code to delete...

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 22, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting code 😍😍😍

@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Dec 22, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Dec 22, 2025
Merged via the queue into ankidroid:main with commit 01ac077 Dec 22, 2025
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 22, 2025
@github-actions github-actions bot added this to the 2.24 release milestone Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants