chore: convert FlagRenameDialog to ViewBinding#19892
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Dec 21, 2025
Merged
Conversation
BrayanDSO
approved these changes
Dec 21, 2025
lukstbit
approved these changes
Dec 21, 2025
harrytmthy
reviewed
Dec 21, 2025
|
|
||
| private fun setupRecyclerView() = | ||
| private fun setupRecyclerView(binding: RenameFlagLayoutBinding) = | ||
| requireActivity().lifecycleScope.launch { |
There was a problem hiding this comment.
Hi @david-allison, I found a lifecycle scope mismatch here. This function is launched on Activity scope, but update a DialogFragment view after suspension. If the dialog is dismissed before createFlagList() resumes, you risk touching a dead view, potentially crashing after dismiss.
Instead, let's tie the job to the dialog's view lifecycle:
lifecycleScope.launch {
val items = withContext(Dispatchers.IO) { createFlagList() }
val adapter = FlagAdapter(lifecycleScope = lifecycleScope)
binding.recyclerViewFlags.layoutManager = LinearLayoutManager(requireContext())
binding.recyclerViewFlags.adapter = adapter
adapter.submitList(items)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
How Has This Been Tested?
Brief test: Open Dialog with Pixel 6 Pro API 35 Emulator
Checklist