Skip to content

chore: convert LocaleSelectionDialog to ViewBinding #19890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukstbit merged 1 commit into from
Dec 21, 2025
Merged

chore: convert LocaleSelectionDialog to ViewBinding #19890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/LocaleSelectionDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import androidx.core.os.bundleOf
import androidx.recyclerview.widget.RecyclerView
import com.ichi2.anki.R
import com.ichi2.anki.analytics.AnalyticsDialogFragment
import com.ichi2.anki.databinding.LocaleSelectionDialogBinding
import com.ichi2.anki.dialogs.LocaleSelectionDialog.LocaleListAdapter.TextViewHolder
import com.ichi2.anki.servicelayer.LanguageHintService
import com.ichi2.ui.AccessibleSearchView
Expand All @@ -53,16 +54,13 @@ class LocaleSelectionDialog : AnalyticsDialogFragment() {
Locale.getAvailableLocales() + IPALanguage,
::sendSelectionResult,
)
val dialogView = layoutInflater.inflate(R.layout.locale_selection_dialog, null)
dialogView
.findViewById<RecyclerView>(R.id.locale_dialog_selection_list)
.adapter = localeAdapter
dialogView
.findViewById<Toolbar>(R.id.locale_dialog_selection_toolbar)
.setupMenuWith(localeAdapter)

val binding = LocaleSelectionDialogBinding.inflate(layoutInflater)
binding.localeDialogSelectionList.adapter = localeAdapter
binding.localeDialogSelectionToolbar.setupMenuWith(localeAdapter)
return AlertDialog.Builder(requireContext()).show {
cancelable(true)
customView(dialogView)
customView(binding.root)
}
}

Expand Down