Skip to content

Comments

chore: convert ExportDialogFragment to ViewBinding#19889

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-ExportDialogFragment
Jan 21, 2026
Merged

chore: convert ExportDialogFragment to ViewBinding#19889
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-ExportDialogFragment

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Small Desktop API 34
    • Fragment opens and export is successful

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 2, 2026
@david-allison david-allison force-pushed the vb-ExportDialogFragment branch from a3644d0 to de4a391 Compare January 5, 2026 11:06
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Jan 5, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 21, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 21, 2026
Merged via the queue into ankidroid:main with commit a000254 Jan 21, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 21, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 21, 2026
@david-allison david-allison deleted the vb-ExportDialogFragment branch January 21, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants