Skip to content

Comments

chore: enable context parameters#19834

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:19614-context-parameters
Dec 17, 2025
Merged

chore: enable context parameters#19834
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:19614-context-parameters

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Dec 17, 2025

Purpose / Description

I've been wanting this for a while. If you know, you know

Experimental; I'm responsible for the full revert if changes are required

Fixes

Approach

Now ktlint-gradle supports it, enable -Xcontext-parameters

How Has This Been Tested?

Trusting CI on this one - and a test-only change

Learning (optional, can help others)

https://kotlinlang.org/docs/context-parameters.html

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Experimental; I'm responsible for the full revert
 if changes are required

https://kotlinlang.org/docs/context-parameters.html

Fixes 19614
@david-allison david-allison marked this pull request as ready for review December 17, 2025 07:51
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what could possible go wrong with this feature:)

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 17, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try!

@BrayanDSO BrayanDSO added this pull request to the merge queue Dec 17, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Dec 17, 2025
Merged via the queue into ankidroid:main with commit a04ef8c Dec 17, 2025
18 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 17, 2025
@github-actions github-actions bot added this to the 2.24 release milestone Dec 17, 2025
@mikehardy
Copy link
Member

This bled into a cherry-pick as NoteEditorTest needed a pick and it requires context parameters now, so I went ahead and picked this to release-2.23 as well. No big deal IMHO but noting it for posterity

@mikehardy
Copy link
Member

scratch that - too much other stuff would drag in. Backing that out of the picked set of commits and will merge the note editor test change with an edit to remove the context parameter need

@david-allison
Copy link
Member Author

Ah dang, that's true, don't bring this into 2.23.

Assign me if this isn't already completed. My responsibility

@david-allison david-allison deleted the 19614-context-parameters branch December 27, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ktlint version and enable Context Parameters

4 participants