chore: enable context parameters#19834
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Dec 17, 2025
Merged
Conversation
Experimental; I'm responsible for the full revert if changes are required https://kotlinlang.org/docs/context-parameters.html Fixes 19614
lukstbit
approved these changes
Dec 17, 2025
Member
lukstbit
left a comment
There was a problem hiding this comment.
I don't see what could possible go wrong with this feature:)
Member
|
This bled into a cherry-pick as NoteEditorTest needed a pick and it requires context parameters now, so I went ahead and picked this to release-2.23 as well. No big deal IMHO but noting it for posterity |
Member
|
scratch that - too much other stuff would drag in. Backing that out of the picked set of commits and will merge the note editor test change with an edit to remove the context parameter need |
Member
Author
|
Ah dang, that's true, don't bring this into 2.23. Assign me if this isn't already completed. My responsibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
I've been wanting this for a while. If you know, you know
Experimental; I'm responsible for the full revert if changes are required
Fixes
Approach
Now ktlint-gradle supports it, enable
-Xcontext-parametersHow Has This Been Tested?
Trusting CI on this one - and a test-only change
Learning (optional, can help others)
https://kotlinlang.org/docs/context-parameters.html
Checklist