Skip to content

Add new filtered deck options implementation #19669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukstbit wants to merge 5 commits into
base: main
Choose a base branch
from
+1,447 −1,105
Open

Add new filtered deck options implementation #19669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38d464d
Add url constant for ankiweb filtered decks related docs
lukstbit Nov 26, 2025
e07675f
Add ConfigureAwareSingleFragmentActivity
lukstbit Nov 26, 2025
660621e
Add implementation for new filtered deck options screen
lukstbit Dec 1, 2025
9e14d8d
Use new filtered deck options code
lukstbit Dec 1, 2025
68a26d0
Remove previous filtered deck options related code
lukstbit Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions AnkiDroid/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,13 +401,6 @@
<category android:name="android.intent.category.MONKEY" />
</intent-filter>
</activity>
<activity
android:name=".FilteredDeckOptions"
android:label="@string/deckpreferences_title"
android:exported="false"
android:configChanges="keyboardHidden|orientation|screenSize"
android:theme="@style/Theme_Light"
/>
<activity
android:name="com.ichi2.anki.Info"
android:label="@string/pref_cat_about_title"
Expand Down Expand Up @@ -470,6 +463,10 @@
android:exported="false"
android:configChanges="orientation|screenSize"
/>
<activity
android:name="com.ichi2.anki.utils.ConfigAwareSingleFragmentActivity"
android:exported="false"
/>
<activity
android:name="com.ichi2.anki.NoteEditorActivity"
android:exported="false"
Expand Down
13 changes: 2 additions & 11 deletions AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ import com.ichi2.anki.dialogs.customstudy.CustomStudyDialog
import com.ichi2.anki.dialogs.customstudy.CustomStudyDialog.CustomStudyAction
import com.ichi2.anki.dialogs.customstudy.CustomStudyDialog.CustomStudyAction.Companion.REQUEST_KEY
import com.ichi2.anki.export.ExportDialogFragment
import com.ichi2.anki.filtered.FilteredDeckOptionsFragment
import com.ichi2.anki.introduction.CollectionPermissionScreenLauncher
import com.ichi2.anki.introduction.hasCollectionStoragePermissions
import com.ichi2.anki.libanki.DeckId
Expand Down Expand Up @@ -1402,17 +1403,7 @@ open class DeckPicker :
}

fun showCreateFilteredDeckDialog() {
val createFilteredDeckDialog =
CreateDeckDialog(this@DeckPicker, R.string.new_deck, CreateDeckDialog.DeckDialogType.FILTERED_DECK, null)
createFilteredDeckDialog.onNewDeckCreated = { deckId ->
// a filtered deck was created
viewModel.openDeckOptions(deckId, isFiltered = true)
}
launchCatchingTask {
withProgress {
createFilteredDeckDialog.showFilteredDeckDialog()
}
}
startActivity(FilteredDeckOptionsFragment.getIntent(this))
}

fun exportCollection() {
Expand Down
Loading